Skip to content

Commit 42537a4

Browse files
authored
Merge pull request goldbergyoni#24 from huhgawz/master
Fix typos and remove unnecessary require
2 parents 01d3fb6 + 9df84f4 commit 42537a4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

readme.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ describe('Products Service', function() {
162162

163163
<br/>
164164

165-
### :clap: Doing It Right Example: A test strcutured with the AAA pattern
165+
### :clap: Doing It Right Example: A test structured with the AAA pattern
166166

167167
![](https://img.shields.io/badge/🔧%20Example%20using%20Jest-blue.svg
168168
"Examples with Jest") ![](https://img.shields.io/badge/🔧%20Example%20using%20Mocha-blue.svg
@@ -456,7 +456,6 @@ it("Better: When adding new valid product, get successful confirmation", async (
456456
```javascript
457457
require('mocha-testcheck').install();
458458
const {expect} = require('chai');
459-
const faker = require('faker');
460459

461460
describe('Product service', () => {
462461
describe('Adding new', () => {
@@ -702,7 +701,7 @@ describe('Order service', function() {
702701
## ⚪ ️1.12 Other generic good testing hygiene
703702
:white_check_mark: **Do:** This post is focused on testing advice that is related to, or at least can be exemplified with Node JS. This bullet, however, groups few non-Node related tips that are well-known
704703

705-
Learn and practice [TDD principles](https://www.sm-cloud.com/book-review-test-driven-development-by-example-a-tldr/) — they are extremely valuable for many but don’t get intimidated if they don’t fit your style, you’re not the only one. Consider writing the tests before the code in a [red-green-refactor style](https://blog.cleancoder.com/uncle-bob/2014/12/17/TheCyclesOfTDD.html), ensure each test checks exactly one thing, when you find a bug — before fixing write a test that will detect this bug in the future, let each test fail at least once before turning green, start a module by writing a quick and simplistic code that satsifies the test - then refactor gradually and take it to a prdoction grade level, avoid any dependency on the environment (paths, OS, etc)
704+
Learn and practice [TDD principles](https://www.sm-cloud.com/book-review-test-driven-development-by-example-a-tldr/) — they are extremely valuable for many but don’t get intimidated if they don’t fit your style, you’re not the only one. Consider writing the tests before the code in a [red-green-refactor style](https://blog.cleancoder.com/uncle-bob/2014/12/17/TheCyclesOfTDD.html), ensure each test checks exactly one thing, when you find a bug — before fixing write a test that will detect this bug in the future, let each test fail at least once before turning green, start a module by writing a quick and simplistic code that satsifies the test - then refactor gradually and take it to a production grade level, avoid any dependency on the environment (paths, OS, etc)
706705
<br/>
707706

708707

@@ -2027,4 +2026,4 @@ Took care to revise, improve, lint and polish all the texts
20272026

20282027
**Role:** Concept, design and great advice
20292028

2030-
**About:** A savvy frontend developer, CSS expert and emojis freak
2029+
**About:** A savvy frontend developer, CSS expert and emojis frea

0 commit comments

Comments
 (0)