Merge pull request JuliaLang#4782 from stevengj/pushitr

support multi-arg push! and unshift!

Author: JeffBezanson

base/abstractarray.jl

@@ -1704,3 +1704,12 @@ function map(f::Callable, As::AbstractArray...)
     dest = similar(As[1], typeof(first), shape)
     return map_to!(f, first, dest, As...)
 end
+
+# multi-item push!, unshift! (built on top of type-specific 1-item version)
+# (note: must not cause a dispatch loop when 1-item case is not defined)
+push!(A) = A
+push!(A, a, b) = push!(push!(A, a), b)
+push!(A, a, b, c...) = push!(push!(A, a, b), c...)
+unshift!(A) = A
+unshift!(A, a, b) = unshift!(unshift!(A, b), a)
+unshift!(A, a, b, c...) = unshift!(unshift!(A, c...), a, b)

doc/helpdb.jl

@@ -1157,9 +1157,9 @@
 
 "),
 
-("Dequeues","Base","push!","push!(collection, item) -> collection
+("Dequeues","Base","push!","push!(collection, items...) -> collection
 
-   Insert an item at the end of a collection.
+   Insert items at the end of a collection.
 
 "),
 
@@ -1169,9 +1169,9 @@
 
 "),
 
-("Dequeues","Base","unshift!","unshift!(collection, item) -> collection
+("Dequeues","Base","unshift!","unshift!(collection, items...) -> collection
 
-   Insert an item at the beginning of a collection.
+   Insert items at the beginning of a collection.
 
 "),
 

doc/stdlib/base.rst

@@ -769,17 +769,17 @@ Partially implemented by: ``Array``.
 Dequeues
 --------
 
-.. function:: push!(collection, item) -> collection
+.. function:: push!(collection, items...) -> collection
 
-   Insert an item at the end of a collection.
+   Insert items at the end of a collection.
 
 .. function:: pop!(collection) -> item
 
    Remove the last item in a collection and return it.
 
-.. function:: unshift!(collection, item) -> collection
+.. function:: unshift!(collection, items...) -> collection
 
-   Insert an item at the beginning of a collection.
+   Insert items at the beginning of a collection.
 
 .. function:: shift!(collection) -> item
 

test/arrayops.jl

@@ -204,14 +204,19 @@ let
 end
 
 ## arrays as dequeues
-l = {1,2,3}
-push!(l,8)
+l = {1}
+push!(l,2,3,8)
 @test l[1]==1 && l[2]==2 && l[3]==3 && l[4]==8
 v = pop!(l)
 @test v == 8
 v = pop!(l)
 @test v == 3
 @test length(l)==2
+unshift!(l,4,7,5)
+@test l[1]==4 && l[2]==7 && l[3]==5 && l[4]==1 && l[5]==2
+v = shift!(l)
+@test v == 4
+@test length(l)==4
 
 # concatenation
 @test isequal([ones(2,2)  2*ones(2,1)], [1. 1 2; 1 1 2])