Skip to content

Conversation

@a7medev
Copy link
Contributor

@a7medev a7medev commented May 1, 2023

Description of the change

Problem

The new Android sourcemaps upload script can’t detect the [create]Bundle[Flavor]ReleaseJsAndAssets when the user is using the Android product flavors feature.

Solution

Check for a suffix of ReleaseJsAndAssets instead of looking for a suffix of bundleReleaseJsAndAssets (ignoring the casing.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #974

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this May 1, 2023
@a7medev a7medev changed the base branch from master to dev May 1, 2023 12:52
@a7medev a7medev marked this pull request as ready for review May 1, 2023 12:52
@a7medev a7medev requested a review from DavidMina96 May 1, 2023 12:52
@InstabugCI
Copy link
Collaborator

InstabugCI commented May 1, 2023

Coverage Report

Label Coverage Status
JavaScript 96.8%
Android 47.8%
iOS 39.0%

Generated by 🚫 dangerJS against deef299

@a7medev a7medev merged commit 2beb1f7 into dev May 2, 2023
@a7medev a7medev deleted the fix/sourcemaps-upload-flavors-support branch May 2, 2023 11:46
@a7medev a7medev restored the fix/sourcemaps-upload-flavors-support branch May 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android build fail when if productFlavors configurated

4 participants