Skip to content

chore(ios): bump sdk to 11.14.0 #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abdelhamid-f-nasser merged 2 commits into from
Sep 12, 2023
Merged

chore(ios): bump sdk to 11.14.0 #1020

abdelhamid-f-nasser merged 2 commits into from
Sep 12, 2023

Conversation

@abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Sep 6, 2023 •
edited
Loading

Description of the change

Bump iOS SDK to 11.14.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

MOB-12991 -- subtask of --> MOB-12984

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser self-assigned this Sep 6, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as draft September 6, 2023 08:18
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 6, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 49.6% ✅
iOS 38.9% ✅

Generated by 🚫 dangerJS against e236e1a

@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from master to dev September 6, 2023 12:06
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review September 6, 2023 12:06
asamiz
asamiz approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @abdelhamid-f-nasser, this is approval from my side

a7medev
a7medev requested changes Sep 10, 2023
View reviewed changes
@abdelhamid-f-nasser
chore(ios): bump ios sdk
288dedd 
Upgrade iOS sdk to 11.14.0
@abdelhamid-f-nasser
docs: update changelog.md
e236e1a 
Add a `#Changed` entry for bump up iOS SDK to 11.14.0
@a7medev a7medev self-requested a review September 11, 2023 10:02
@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 71449bc into dev Sep 12, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the native/ios/11.14.0 branch September 12, 2023 11:21
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@abdelhamid-f-nasser @HeshamMegid
chore(ios): bump sdk to 11.14.0 (#1020)
3173ade 
Jira ID: MOB-12991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a7medev a7medev a7medev approved these changes

+1 more reviewer

@asamiz asamiz asamiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abdelhamid-f-nasser abdelhamid-f-nasser

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abdelhamid-f-nasser @InstabugCI @asamiz @a7medev