chore: ignore non-error promise rejections

Author: a7medev

src/utils/InstabugUtils.ts

@@ -92,20 +92,6 @@ export const stringifyIfNotString = (input: unknown) => {
   return typeof input === 'string' ? input : JSON.stringify(input);
 };
 
-export const errorifyIfNotError = (value: unknown): Error => {
-  if (value instanceof Error) {
-    return value;
-  }
-
-  const message = stringifyIfNotString(value);
-  const error = new Error(message);
-
-  // Empty the stack trace since it'd be inaccurate
-  error.stack = '';
-
-  return error;
-};
-
 export const invokeDeprecatedCallback = <T>(callback?: (arg: T) => void, arg?: T | null) => {
   if (!callback) {
     return;

src/utils/UnhandledRejectionTracking.ts

@@ -1,5 +1,5 @@
 import tracking, { RejectionTrackingOptions } from 'promise/setimmediate/rejection-tracking';
-import { errorifyIfNotError, sendCrashReport } from './InstabugUtils';
+import { sendCrashReport } from './InstabugUtils';
 import { NativeCrashReporting } from '../native/NativeCrashReporting';
 
 export interface HermesInternalType {
@@ -75,9 +75,9 @@ function _onUnhandled(id: number, rejection: unknown) {
     return;
   }
 
-  const error = errorifyIfNotError(rejection);
-
-  sendCrashReport(error, NativeCrashReporting.sendHandledJSCrash);
+  if (rejection instanceof Error) {
+    sendCrashReport(rejection, NativeCrashReporting.sendHandledJSCrash);
+  }
 }
 
 /* istanbul ignore next */

test/utils/InstabugUtils.spec.ts

@@ -7,11 +7,7 @@ import parseErrorStackLib from 'react-native/Libraries/Core/Devtools/parseErrorS
 import * as Instabug from '../../src/modules/Instabug';
 import { NativeCrashReporting } from '../../src/native/NativeCrashReporting';
 import { InvocationEvent } from '../../src/utils/Enums';
-import InstabugUtils, {
-  errorifyIfNotError,
-  getStackTrace,
-  sendCrashReport,
-} from '../../src/utils/InstabugUtils';
+import InstabugUtils, { getStackTrace, sendCrashReport } from '../../src/utils/InstabugUtils';
 
 describe('Test global error handler', () => {
   beforeEach(() => {
@@ -265,22 +261,4 @@ describe('Instabug Utils', () => {
     expect(remoteSenderCallback).toHaveBeenCalledTimes(1);
     expect(remoteSenderCallback).toHaveBeenCalledWith(expectedMap);
   });
-
-  it('errorifyIfNotError should convert non-errors into an error', () => {
-    const message = 'Something went wrong';
-
-    const result = errorifyIfNotError(message);
-
-    expect(result).toBeInstanceOf(Error);
-    expect(result.message).toBe(message);
-    expect(result.stack).toBe('');
-  });
-
-  it('errorifyIfNotError should not affect errors', () => {
-    const error = new TypeError('Something went wrong');
-
-    const result = errorifyIfNotError(error);
-
-    expect(result).toBe(error);
-  });
 });

test/utils/UnhandledRejectionTracking.spec.ts

@@ -36,27 +36,25 @@ it('tracks Promise rejections when using `promise` polyfill', () => {
   });
 });
 
-it.each([new Error(), "Couldn't fetch data"])(
-  'reports unhandled Promise rejections in release mode',
-  (rejection) => {
-    const mockDev = mockDevMode(false);
-    const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
+it('reports unhandled Promise rejections in release mode', () => {
+  const mockDev = mockDevMode(false);
+  const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
 
-    const id = 123;
+  const rejection = new Error('something went wrong');
+  const id = 123;
 
-    // Simulate an immediate unhandled promise rejection
-    mocked(tracking.enable).mockImplementationOnce((options) => {
-      options?.onUnhandled?.(id, rejection);
-    });
+  // Simulate an immediate unhandled promise rejection
+  mocked(tracking.enable).mockImplementationOnce((options) => {
+    options?.onUnhandled?.(id, rejection);
+  });
 
-    captureUnhandledRejections();
+  captureUnhandledRejections();
 
-    expect(NativeCrashReporting.sendHandledJSCrash).toBeCalledTimes(1);
+  expect(NativeCrashReporting.sendHandledJSCrash).toBeCalledTimes(1);
 
-    mockDev.mockRestore();
-    consoleWarnSpy.mockRestore();
-  },
-);
+  mockDev.mockRestore();
+  consoleWarnSpy.mockRestore();
+});
 
 it('does not report unhandled Promise rejections in dev mode', () => {
   const mockDev = mockDevMode(true);
@@ -77,3 +75,23 @@ it('does not report unhandled Promise rejections in dev mode', () => {
   mockDev.mockRestore();
   consoleWarnSpy.mockRestore();
 });
+
+it('does not report non-error unhandled Promise rejections', () => {
+  const mockDev = mockDevMode(true);
+  const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
+
+  const id = 123;
+  const rejection = 'something went wrong';
+
+  // Simulate an immediate unhandled promise rejection
+  mocked(tracking.enable).mockImplementationOnce((options) => {
+    options?.onUnhandled?.(id, rejection);
+  });
+
+  captureUnhandledRejections();
+
+  expect(NativeCrashReporting.sendHandledJSCrash).not.toBeCalled();
+
+  mockDev.mockRestore();
+  consoleWarnSpy.mockRestore();
+});