refactor(android): better addRef/releaseRef node semantics

Author: IjzerenHein

android/src/main/java/com/ijzerenhein/sharedelement/RNSharedElementNode.java

@@ -70,16 +70,24 @@ int getReactTag() {
         return mReactTag;
     }
 
-    int getRefCount() {
-        return mRefCount;
+    int addRef() {
+        return ++mRefCount;
     }
 
-    void setRefCount(int refCount) {
-        mRefCount = refCount;
-        if (mRefCount == 0) {
+    int releaseRef() {
+        if (--mRefCount == 0) {
             removeDraweeControllerListener(mResolvedView);
             stopRetryLoop();
+            mView = null;
+            mAncestorView = null;
+            mStyleConfig = null;
+            mResolvedView = null;
+            mContentCache = null;
+            mContentCallbacks = null;
+            mStyleCache = null;
+            mStyleCallbacks = null;
         }
+        return mRefCount;
     }
 
     void addHideRef() {

android/src/main/java/com/ijzerenhein/sharedelement/RNSharedElementNodeManager.java

@@ -30,7 +30,7 @@ RNSharedElementNode acquire(int reactTag, View view, boolean isParent, View ance
         synchronized (mNodes) {
             RNSharedElementNode node = mNodes.get(reactTag);
             if (node != null) {
-                node.setRefCount(node.getRefCount() + 1);
+                node.addRef();
                 return node;
             }
             node = new RNSharedElementNode(mContext, reactTag, view, isParent, ancestor, styleConfig);
@@ -41,11 +41,11 @@ RNSharedElementNode acquire(int reactTag, View view, boolean isParent, View ance
 
     int release(RNSharedElementNode node) {
         synchronized (mNodes) {
-            node.setRefCount(node.getRefCount() - 1);
-            if (node.getRefCount() == 0) {
+            int refCount = node.releaseRef();
+            if (refCount == 0) {
                 mNodes.remove(node.getReactTag());
             }
-            return node.getRefCount();
+            return refCount;
         }
     }
 }