Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mitreid-connect/OpenID-Connect-Java-Spring-Server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: HeXetic/OpenID-Connect-Java-Spring-Server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 15, 2016

  1. createAuthorizationCode should be @transactional 

    An Authentication should not exist without its matching AuthorizationCode, but typically an AuthorizationCode will have a foreign key on an Authentication, meaning it can't be saved first. This block should be wrapped in a transaction so that other DB clients (say, for example, clearExpiredAuthorizationCodes) don't see an inconsistent snapshot and then misbehave.
    @HeXetic
    HeXetic authored Jul 15, 2016
    Configuration menu
    Copy the full SHA
    5d2dcc3 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from HeXetic/createAuthorizationCode_transactional 

    createAuthorizationCode should be @transactional
    @HeXetic
    HeXetic authored Jul 15, 2016
    Configuration menu
    Copy the full SHA
    aca15fc View commit details
    Browse the repository at this point in the history
Loading