Post standard License.

Try to create a nuget package.

Author: HarryCordewener

.github/workflows/dotnet.yml

@@ -22,4 +22,6 @@ jobs:
     - name: Build
       run: dotnet build --no-restore
     - name: Test
-      run: dotnet test --no-build --verbosity normal
+      run: dotnet test --no-build --verbosity normal
+    - name: Push nuget package
+      run: dotnet nuget push "*.nupkg" -k ${{ secrets.NUGET_TOKEN }}

CHANGELOG.md

@@ -0,0 +1,17 @@
+# Change Log
+All notable changes to this project will be documented in this file.
+ 
+## [1.0.0] - 2024-01-03
+  
+Initial version.
+ 
+### Added
+- Initial support for RFC855 (TELOPT)
+- Initial support for RFC858 (GOAHEAD)
+- Initial support for RFC1091 (TTERM)
+- Initial support for MTTS
+- Initial support for RFC885 (EOR)
+- Initial support for RFC1073 (NAWS)
+- Initial support for RFC2066 (CHARSET)
+- Initial support for MSSP
+- Initial support for GMCP

LICENSE

@@ -0,0 +1,13 @@
+Copyright [2024] [Harry Cordewener]
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.

Telnet.png

@@ -25,7 +25,7 @@ public MockClient(string ip, int port, ILogger? logger = null)
 
 			while (true)
 			{
-				var read = Console.ReadLine() + "\n\r" + "\r\n";
+				var read = Console.ReadLine() + "\n\r";
 				telnet?.SendPromptAsync(telnet?.CurrentEncoding.GetBytes(read)).GetAwaiter().GetResult();
 			}
 		}
@@ -35,7 +35,7 @@ public MockClient(string ip, int port, ILogger? logger = null)
 		public Task WriteBack(byte[] writeback, Encoding encoding)
 		{
 			string str = encoding.GetString(writeback);
-			_Logger.Information("Writeback: {writeBack}", str);
+			Console.WriteLine(str);
 			return Task.CompletedTask;
 		}
 
@@ -52,7 +52,7 @@ public Task SignalNAWS(int height, int width)
 			return Task.CompletedTask;
 		}
 
-		public void Handle(object obj)
+		public void Handle(object? obj)
 		{
 			var client = (TcpClient)obj;
 			int port = -1;

TelnetNegotiationCore.TestClient/MockClient.cs

@@ -15,7 +15,7 @@ static void Main()
 				.CreateLogger();
 
 			Log.Logger = log;
-			var server = new MockClient("127.0.0.1", 4201, log.ForContext<MockClient>());
+			var _ = new MockClient("127.0.0.1", 4201, log.ForContext<MockClient>());
 		}
 	}
 }

TelnetNegotiationCore.TestClient/Program.cs

@@ -10,12 +10,13 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Files", "Solution Files", "{444703E8-4E7D-48CE-9F96-E510E3A99FA5}"
 	ProjectSection(SolutionItems) = preProject
 		CHANGELOG.md = CHANGELOG.md
+		LICENSE = LICENSE
 		README.md = README.md
 	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TelnetNegotiationCore.UnitTests", "TelnetNegotiationCore.UnitTests\TelnetNegotiationCore.UnitTests.csproj", "{0EC8EB89-8596-4426-83B0-29354F5B8938}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "TelnetNegotiationCore.TestClient", "TelnetNegotiationCore.TestClient\TelnetNegotiationCore.TestClient.csproj", "{E1A76C78-8246-472F-824E-9F7F9B3778B7}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TelnetNegotiationCore.TestClient", "TelnetNegotiationCore.TestClient\TelnetNegotiationCore.TestClient.csproj", "{E1A76C78-8246-472F-824E-9F7F9B3778B7}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

TelnetNegotiationCore.sln

@@ -156,6 +156,13 @@ private StateMachine<State, Trigger> SetupStandardProtocol(StateMachine<State, T
 				.Permit(Trigger.SB, State.SubNegotiation)
 				.OnEntry(x => _Logger.Debug("Connection: {connectionState}", "Starting Negotiation"));
 
+			tsm.Configure(State.StartNegotiation)
+				.Permit(Trigger.NOP, State.DoNothing);
+
+			tsm.Configure(State.DoNothing)
+				.SubstateOf(State.Accepting)
+				.OnEntry(() => _Logger.Debug("Connection: {connectionState}", "NOP call. Do nothing."));
+
 			// As a general documentation, negotiation means a Do followed by a Will, or a Will followed by a Do.
 			// Do followed by Refusing or Will followed by Don't indicate negative negotiation.
 			tsm.Configure(State.Willing);

TelnetNegotiationCore/Interpreters/TelnetStandardInterpreter.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Text.Json.Serialization;
 
 namespace TelnetNegotiationCore.Models
 {

TelnetNegotiationCore/Models/MSSPConfig.cs

@@ -9,6 +9,7 @@ public enum State : sbyte
 		EndNegotiation,
 		SubNegotiation,
 		EndSubNegotiation,
+		DoNothing,
 		Do,
 		Dont,
 		Willing,

TelnetNegotiationCore/Models/State.cs

@@ -61,58 +61,74 @@ public enum Trigger : short
 		/// Sub-negotiation SEND command
 		/// ECHO negotiation (Unsupported)
 		/// Sub-negotiation MSSP_VAR
+		/// Sub-negotiation MSDP_VAR
 		/// </summary>
 		/// <remarks>
 		/// RFC 855: http://www.faqs.org/rfcs/rfc855.html
 		/// RFC 857: http://www.faqs.org/rfcs/rfc857.html
 		/// RFC 2066: http://www.faqs.org/rfcs/rfc2066.html
 		/// MSSP: https://tintin.mudhalla.net/protocols/mssp/
+		/// MSDP: https://tintin.mudhalla.net/protocols/msdp/
 		/// </remarks>
 		ECHO = 1,
 		MSSP_VAR = 1,
+		MSDP_VAR = 1,
 		SEND = 1,
 		REQUEST = 1,
 		/// <summary>
 		/// Sub-negotiation ACCEPTED command.	
-		/// Sub-negotiation MSSP_VAR
+		/// Sub-negotiation MSSP_VAL
+		/// Sub-negotiation MSDP_VAL
 		/// </summary>
 		/// <remarks>
 		/// MSSP: https://tintin.mudhalla.net/protocols/mssp/
 		/// RFC 2066: http://www.faqs.org/rfcs/rfc2066.html
+		/// MSDP: https://tintin.mudhalla.net/protocols/msdp/
 		/// </remarks>
 		MSSP_VAL = 2,
+		MSDP_VAL = 2,
 		ACCEPTED = 2,
 		/// <summary>
 		/// Sub-negotiation REJECTED command.	
 		/// Suppress Go Ahead
+		/// Sub-negotiation MSDP_TABLE_OPEN
 		/// </summary>
 		/// <remarks>
 		/// RFC 858: http://www.faqs.org/rfcs/rfc858.html
 		/// RFC 2066: http://www.faqs.org/rfcs/rfc2066.html
+		/// MSDP: https://tintin.mudhalla.net/protocols/msdp/
 		/// </remarks>
 		SUPPRESSGOAHEAD = 3,
 		REJECTED = 3,
+		MSDP_TABLE_OPEN = 3,
 		/// <summary>
 		/// Sub-negotiation TTABLE-IS command. (Unsupported)
+		/// Sub-negotiation MSDP_TABLE_CLOSE
 		/// </summary>
 		/// <remarks>
 		/// RFC 2066: http://www.faqs.org/rfcs/rfc2066.html
+		/// MSDP: https://tintin.mudhalla.net/protocols/msdp/
 		/// </remarks>
 		TTABLE_IS = 4,
+		MSDP_TABLE_CLOSE = 4,
 		/// <summary>
 		/// Sub-negotiation TTABLE_REJECTED command. (Unsupported)
+		/// Sub-negotiation MSDP_ARRAY_OPEN
 		/// </summary>
 		/// <remarks>
 		/// RFC 2066: http://www.faqs.org/rfcs/rfc2066.html
 		/// </remarks>
 		TTABLE_REJECTED = 5,
+		MSDP_ARRAY_OPEN = 5,
 		/// <summary>
 		/// Sub-negotiation TTABLE_ACK command. (Unsupported)
+		/// Sub-negotiation MSDP_ARRAY_CLOSE   
 		/// </summary>
 		/// <remarks>
 		/// RFC 2066: http://www.faqs.org/rfcs/rfc2066.html
 		/// </remarks>
 		TTABLE_ACK = 6,
+		MSDP_ARRAY_CLOSE = 6,
 		/// <summary>
 		/// Sub-negotiation TTABLE_NAK command. (Unsupported)
 		/// </summary>

TelnetNegotiationCore/Models/Trigger.cs

@@ -4,20 +4,47 @@
     <TargetFramework>net6.0</TargetFramework>
 	  <LangVersion>latest</LangVersion>
 		<Version>1.0.0</Version>
+		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+		<Title>Telnet Negotiation Core</Title>
+		<PackageId>$(AssemblyName)</PackageId>
+		<Authors>harrycordewener</Authors>
+		<Description>A Client and Server compatible library to create telnet applications, with a mind to MUDs.</Description>
+		<PackageProjectUrl>https://github.com/HarryCordewener/TelnetNegotiationCore/wiki</PackageProjectUrl>
+		<PackageIcon>Telnet.png</PackageIcon>
+		<PackageReadmeFile>README.md</PackageReadmeFile>
+		<RepositoryUrl>https://github.com/HarryCordewener/TelnetNegotiationCore</RepositoryUrl>
+		<RepositoryType>git</RepositoryType>
+		<PackageTags>telnet</PackageTags>
+		<PackageLicenseFile>LICENSE</PackageLicenseFile>
+	  <PackageReleaseNotes>$([System.IO.File]::ReadAllText("CHANGELOG.md"))</PackageReleaseNotes>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
+  <ItemGroup>
+    <None Include="..\README.md">
+      <Pack>True</Pack>
+      <PackagePath>\</PackagePath>
+    </None>
+    <None Include="..\Telnet.png">
+      <Pack>True</Pack>
+      <PackagePath>\</PackagePath>
+    </None>
+  </ItemGroup>
+	<ItemGroup>
+		<None Include="..\LICENSE" Pack="true" PackagePath=""/>
+	</ItemGroup>
+	
   <ItemGroup>
     <PackageReference Include="morelinq" Version="3.4.2" />
     <PackageReference Include="OneOf" Version="3.0.255" />
     <PackageReference Include="Serilog" Version="3.0.1" />
     <PackageReference Include="Serilog.Sinks.Console" Version="4.1.0" />
     <PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
     <PackageReference Include="stateless" Version="5.13.0" />
-    <PackageReference Include="System.Collections.Immutable" Version="8.0.0-preview.7.23375.6" />
+    <PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
   </ItemGroup>
 
 </Project>