Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Project structure to use gradle #1164

Merged
merged 15 commits into from
Apr 9, 2018

Conversation

cedricziel
Copy link
Contributor

The project depends on the toolbox and the annotation plugin, so this
will only ever build if they update first.

The project depends on the toolbox and the annotation plugin, so this
will only ever build if they update first.
@cedricziel cedricziel changed the title Migrate Project structure to use gradle [WIP] Migrate Project structure to use gradle Mar 22, 2018
@cedricziel
Copy link
Contributor Author

@Haehnchen There's many tests that are supposed to not run when PHPSTORM_ENV is set. How should we handle these? Am I right those are sketched and not ready yet? If yes, how should we handle them? By now, they break the build and they will surely annoy future contributors.

@cedricziel
Copy link
Contributor Author

Two test classes were not found by the ant script glob. I renamed them in 68b83a5 to get into a state where we have been before and the build should become stable again for the 2017.3 line.

@Haehnchen
Copy link
Owner

@cedricziel tests about PHPSTORM_ENV can be disabled. simply they are not working without a full project right now.

@cedricziel cedricziel changed the title [WIP] Migrate Project structure to use gradle Migrate Project structure to use gradle Mar 23, 2018
@cedricziel
Copy link
Contributor Author

@Haehnchen Alright, the PRs are all ready to be merged.

We should start with Haehnchen/idea-php-toolbox#79 and tag it with 0.4.7 or something else i can then adjust in the other PRs to.

Then Haehnchen/idea-php-annotation-plugin#110 needs another run on travis, but i expect it to be green as well.

After that, the main plugin (this PR) is next. The laravel plugin one is green as well.

Thx in advance!

@cedricziel
Copy link
Contributor Author

@Haehnchen Upgraded to stable 2018.1 platform requirements, fixed 2 OpenAPI issues and it's green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants