Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash tag support for constructor #1015

Closed
podhy opened this issue Sep 6, 2017 · 9 comments
Closed

Hash tag support for constructor #1015

podhy opened this issue Sep 6, 2017 · 9 comments
Labels

Comments

@podhy
Copy link
Contributor

podhy commented Sep 6, 2017

Hello,
I discovered this cool feature and tried to use it, but it doesnt work with constructor parameters.

My enviroment is:

  • PHPStrom 2017.2.2
  • Symfony plugin 0.14.151
@King2500
Copy link
Contributor

King2500 commented Sep 6, 2017

Related to Haehnchen/idea-php-toolbox#50 ?

@Haehnchen
Copy link
Owner

I think he meant:

__construct($foo, $foobar);
services:
  Foobar\Bar:
    arguments:
      foo: '@my_service'

@podhy
Copy link
Contributor Author

podhy commented Sep 6, 2017

@King2500 yes this is what I mean (I was trying #Route hash tag). Sorry for duplicate issue. Couldn find it. Maybe I look at it and try to resolve.

@podhy podhy closed this as completed Sep 15, 2017
@podhy
Copy link
Contributor Author

podhy commented Sep 17, 2017

Sorry. I had to reopen. It still doesnt work with #Route hash tag. Haehnchen/idea-php-toolbox#74 fixes only #Class hash tag. I will look at it.

@podhy podhy reopened this Sep 17, 2017
@King2500
Copy link
Contributor

It should work for all providers. Including custom ones from json.

@podhy
Copy link
Contributor Author

podhy commented Sep 17, 2017

Yeah. But I'm currently testing it in PHPStomr and I cant get it work. In constructor I still get No suggestion.

And I cant get working symfony2 plugin with php toolbox so I can debug it.

@podhy
Copy link
Contributor Author

podhy commented Sep 17, 2017

ohh I found it. I will clean my code and make PR.

@podhy
Copy link
Contributor Author

podhy commented Sep 17, 2017

#1024 fix

@Haehnchen
Copy link
Owner

thx, so fixed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants