Extract service map parsing logic to a class and test it

Author: adrienbrault

.idea/libraries/junit_junit_4_9.xml

@@ -0,0 +1,52 @@
+package fr.adrienbrault.idea.symfony2plugin;
+
+import org.w3c.dom.*;
+import org.xml.sax.SAXException;
+
+import javax.xml.parsers.*;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * @author Adrien Brault <adrien.brault@gmail.com>
+ */
+public class ServiceMapParser {
+
+    private DocumentBuilder documentBuilder;
+
+    public ServiceMapParser() throws ParserConfigurationException {
+        DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
+        documentBuilder = dbFactory.newDocumentBuilder();
+    }
+
+    public Map<String, String> parse(InputStream stream) throws IOException, SAXException {
+        return parse(documentBuilder.parse(stream));
+    }
+
+    public Map<String, String> parse(File file) throws IOException, SAXException {
+        return parse(documentBuilder.parse(file));
+    }
+
+    public Map<String, String> parse(Document document) {
+        Map<String, String> map = new HashMap<String, String>();
+
+        NodeList servicesNodes = document.getElementsByTagName("service");
+        for (int i = 0; i < servicesNodes.getLength(); i++) {
+            Element node = (Element) servicesNodes.item(i);
+            if (node.hasAttribute("class") && node.hasAttribute("id")) {
+                map.put(node.getAttribute("id"), "\\" + node.getAttribute("class"));
+            }
+        }
+
+        // Support services whose class isn't specified
+        map.put("request", "\\Symfony\\Component\\HttpFoundation\\Request");
+        map.put("service_container", "\\Symfony\\Component\\DependencyInjection\\ContainerInterface");
+        map.put("kernel", "\\Symfony\\Component\\HttpKernel\\KernelInterface");
+
+        return map;
+    }
+
+}

lib/hamcrest-core-1.1.jar

@@ -102,42 +102,19 @@ private String getServiceId(MethodReferenceImpl e) {
             return cachedServiceMap;
         }
 
-        Document doc = null;
         try {
-            DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
-            DocumentBuilder dBuilder = dbFactory.newDocumentBuilder();
-            doc = dBuilder.parse(xmlFile);
+            ServiceMapParser serviceMapParser = new ServiceMapParser();
+            cachedServiceMap = serviceMapParser.parse(xmlFile);
+            cachedServiceMapLastModified = xmlFileLastModified;
         } catch (SAXException e) {
-            e.printStackTrace();
-
             return map;
         } catch (IOException e) {
-            e.printStackTrace();
-
             return map;
         } catch (ParserConfigurationException e) {
-            e.printStackTrace();
-
             return map;
         }
 
-        NodeList servicesNodes = doc.getElementsByTagName("service");
-        for (int i = 0; i < servicesNodes.getLength(); i++) {
-            Element node = (Element) servicesNodes.item(i);
-            if (node.hasAttribute("class") && node.hasAttribute("id")) {
-                map.put(node.getAttribute("id"), "\\" + node.getAttribute("class"));
-            }
-        }
-
-        // Support services whose class isn't specified
-        map.put("request", "\\Symfony\\Component\\HttpFoundation\\Request");
-        map.put("service_container", "\\Symfony\\Component\\DependencyInjection\\ContainerInterface");
-        map.put("kernel", "\\Symfony\\Component\\HttpKernel\\KernelInterface");
-
-        cachedServiceMap = map;
-        cachedServiceMapLastModified = xmlFileLastModified;
-
-        return map;
+        return cachedServiceMap;
     }
 
 }

lib/junit-4.9.jar

@@ -5,11 +5,13 @@
     <exclude-output />
     <content url="file://$MODULE_DIR$">
       <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" />
+      <sourceFolder url="file://$MODULE_DIR$/tests" isTestSource="true" />
     </content>
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" scope="PROVIDED" name="php-openapi" level="project" />
     <orderEntry type="library" scope="PROVIDED" name="php" level="project" />
+    <orderEntry type="library" scope="TEST" name="junit:junit:4.9" level="project" />
   </component>
 </module>
 

src/fr/adrienbrault/idea/symfony2plugin/ServiceMapParser.java

@@ -0,0 +1,30 @@
+package fr.adrienbrault.idea.symfony2plugin.tests;
+
+import fr.adrienbrault.idea.symfony2plugin.ServiceMapParser;
+import org.junit.Test;
+import org.junit.Assert;
+
+import java.io.ByteArrayInputStream;
+import java.util.Map;
+
+/**
+ * @author Adrien Brault <adrien.brault@gmail.com>
+ */
+public class ServiceMapParserTest extends Assert {
+
+    @Test
+    public void testParse() throws Exception {
+        ServiceMapParser serviceMapParser = new ServiceMapParser();
+
+        String xmlString = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" +
+                "<container><service id=\"adrienbrault\" class=\"AdrienBrault\\Awesome\"/></container>";
+        Map<String, String> serviceMap = serviceMapParser.parse(new ByteArrayInputStream(xmlString.getBytes()));
+
+        assertEquals("\\AdrienBrault\\Awesome", serviceMap.get("adrienbrault"));
+
+        assertEquals("\\Symfony\\Component\\HttpFoundation\\Request", serviceMap.get("request"));
+        assertEquals("\\Symfony\\Component\\DependencyInjection\\ContainerInterface", serviceMap.get("service_container"));
+        assertEquals("\\Symfony\\Component\\HttpKernel\\KernelInterface", serviceMap.get("kernel"));
+    }
+
+}