Merge pull request #1641 from adamwojs/issue_1640

Fixed #1640: Go to declaration throws ArrayIndexOutOfBoundsException on empty class const name

Author: Haehnchen

src/main/java/fr/adrienbrault/idea/symfony2plugin/dic/container/util/ServiceContainerUtil.java

@@ -731,6 +731,11 @@ public static Collection<PsiElement> getTargetsForConstant(@NotNull Project proj
         contents = contents.replaceAll(":+", ":");
         String[] split = contents.split(":");
 
+        if (split.length < 2) {
+            // Empty const name e.g. "\\App\\Foo::"
+            return Collections.emptyList();
+        }
+
         Collection<PsiElement> psiElements = new ArrayList<>();
         for (PhpClass phpClass : PhpElementsUtil.getClassesInterface(project, split[0])) {
             Field fieldByName = phpClass.findFieldByName(split[1], true);

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/dic/container/util/ServiceContainerUtilTest.java

@@ -357,6 +357,10 @@ public void testVisitNamedArguments() {
         assertFalse(arguments.contains("private"));
     }
 
+    public void testGetTargetsForConstantForEmptyClassConstName() {
+        assertEmpty(ServiceContainerUtil.getTargetsForConstant(getProject(), "\\App\\Service\\FooService::"));
+    }
+
     private static class MyStringServiceInterfaceCondition implements Condition<ServiceInterface> {
 
         @NotNull

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/dic/container/util/fixtures/classes.php

@@ -26,4 +26,12 @@ private function fooPrivate($private)
         {
         }
     }
+}
+
+namespace App\Service
+{
+    class FooService
+    {
+        public const FOO = "foo";
+    }
 }