autocompletion for known tag names in Definition::addTag, clearTag, hasTag #955

Author: Haehnchen

src/fr/adrienbrault/idea/symfony2plugin/config/php/PhpConfigReferenceContributor.java

@@ -43,6 +43,9 @@ public void registerReferenceProviders(PsiReferenceRegistrar psiReferenceRegistr
 
         psiReferenceRegistrar.registerReferenceProvider(PhpElementsUtil.methodWithFirstStringPattern(), new PhpStringLiteralExpressionReference(TagReference.class)
             .addCall("\\Symfony\\Component\\DependencyInjection\\ContainerBuilder", "findTaggedServiceIds")
+            .addCall("\\Symfony\\Component\\DependencyInjection\\Definition", "addTag")
+            .addCall("\\Symfony\\Component\\DependencyInjection\\Definition", "hasTag")
+            .addCall("\\Symfony\\Component\\DependencyInjection\\Definition", "clearTag")
         );
 
         psiReferenceRegistrar.registerReferenceProvider(PhpElementsUtil.methodWithFirstStringPattern(), new PhpStringLiteralExpressionReference(EventDispatcherEventReference.class)

tests/fr/adrienbrault/idea/symfony2plugin/tests/config/php/PhpConfigReferenceContributorTest.java

@@ -0,0 +1,42 @@
+package fr.adrienbrault.idea.symfony2plugin.tests.config.php;
+
+import com.jetbrains.php.lang.PhpFileType;
+import fr.adrienbrault.idea.symfony2plugin.tests.SymfonyLightCodeInsightFixtureTestCase;
+
+import java.io.File;
+
+/**
+ * @author Daniel Espendiller <daniel@espendiller.net>
+ * @see fr.adrienbrault.idea.symfony2plugin.config.php.PhpConfigReferenceContributor
+ */
+public class PhpConfigReferenceContributorTest extends SymfonyLightCodeInsightFixtureTestCase {
+    public void setUp() throws Exception {
+        super.setUp();
+        myFixture.copyFileToProject("classes.php");
+        myFixture.copyFileToProject("tags.yml");
+    }
+
+    public String getTestDataPath() {
+        return new File(this.getClass().getResource("fixtures").getFile()).getAbsolutePath();
+    }
+
+    public void testTagReferences() {
+        assertCompletionContains(PhpFileType.INSTANCE, "<?php\n" +
+                "/** @var $x \\Symfony\\Component\\DependencyInjection\\Definition */\n" +
+                "$x->addTag('<caret>')",
+            "foobar"
+        );
+
+        assertCompletionContains(PhpFileType.INSTANCE, "<?php\n" +
+                "/** @var $x \\Symfony\\Component\\DependencyInjection\\Definition */\n" +
+                "$x->clearTag('<caret>')",
+            "foobar"
+        );
+
+        assertCompletionContains(PhpFileType.INSTANCE, "<?php\n" +
+                "/** @var $x \\Symfony\\Component\\DependencyInjection\\Definition */\n" +
+                "$x->hasTag('<caret>')",
+            "foobar"
+        );
+    }
+}

tests/fr/adrienbrault/idea/symfony2plugin/tests/config/php/fixtures/classes.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection
+{
+    class Definition
+    {
+        public function addTag($name, array $attributes = array())
+        {
+        }
+
+        public function hasTag($name)
+        {
+        }
+
+        public function clearTag($name)
+        {
+        }
+    }
+}

tests/fr/adrienbrault/idea/symfony2plugin/tests/config/php/fixtures/tags.yml

@@ -0,0 +1,5 @@
+services:
+    my_foobar:
+        class: espend\Form\TypeBundle\Form\FooType
+        tags:
+            - { name: foobar }