use slash for controller subfolder which are PHP namespaces instead of filesystem style to fix autocompletion for controller names in routing files is broken for namespaced classes #961

Author: Haehnchen

src/fr/adrienbrault/idea/symfony2plugin/util/controller/ControllerIndex.java

@@ -114,7 +114,7 @@ private List<ControllerAction> getActionMethods(SymfonyBundle symfonyBundle) {
             for(Method method : phpClass.getMethods()) {
                 String methodName = method.getName();
                 if(methodName.endsWith("Action") && method.getAccess().isPublic()) {
-                    String shortcutName = symfonyBundle.getName() + ":" + ns.replace("\\", "/") + ':' + methodName.substring(0, methodName.length() - 6);
+                    String shortcutName = symfonyBundle.getName() + ":" + ns.replace("/", "\\") + ':' + methodName.substring(0, methodName.length() - 6);
                     actions.add(new ControllerAction(shortcutName, method));
                 }
 

tests/fr/adrienbrault/idea/symfony2plugin/tests/util/controller/ControllerIndexTest.java

@@ -0,0 +1,39 @@
+package fr.adrienbrault.idea.symfony2plugin.tests.util.controller;
+
+import fr.adrienbrault.idea.symfony2plugin.tests.SymfonyLightCodeInsightFixtureTestCase;
+import fr.adrienbrault.idea.symfony2plugin.util.controller.ControllerAction;
+import fr.adrienbrault.idea.symfony2plugin.util.controller.ControllerIndex;
+
+import java.io.File;
+import java.util.Collection;
+
+/**
+ * @author Daniel Espendiller <daniel@espendiller.net>
+ */
+public class ControllerIndexTest extends SymfonyLightCodeInsightFixtureTestCase {
+
+    public void setUp() throws Exception {
+        super.setUp();
+        myFixture.copyFileToProject("classes.php");
+    }
+
+    public String getTestDataPath() {
+        return new File(this.getClass().getResource("fixtures").getFile()).getAbsolutePath();
+    }
+
+    public void testThatControllerActionsForBundlesAreGenerated() {
+        Collection<ControllerAction> actions = new ControllerIndex(getProject()).getActions();
+
+        assertNotNull(
+            actions.stream().findFirst().filter(action -> "FooBundle:Foo:foo".equals(action.getShortcutName()))
+        );
+
+        assertNotNull(
+            actions.stream().findFirst().filter(action -> "FooBundle:Apple\\Foo:foo".equals(action.getShortcutName()))
+        );
+
+        assertNotNull(
+            actions.stream().findFirst().filter(action -> "FooBundle:Apple\\Bar\\Foo:foo".equals(action.getShortcutName()))
+        );
+    }
+}

tests/fr/adrienbrault/idea/symfony2plugin/tests/util/controller/fixtures/classes.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Symfony\Component\HttpKernel\Bundle{
+    interface Bundle {}
+}
+
+namespace FooBundle {
+    class FooBundle implements \Symfony\Component\HttpKernel\Bundle\Bundle {}
+}
+
+namespace FooBundle\Controller {
+    class FooController {
+        public function fooAction() {}
+    }
+}
+
+namespace FooBundle\Controller\Apple {
+    class FooController {
+        public function fooAction() {}
+    }
+}
+
+namespace FooBundle\Controller\Apple\Bar {
+    class FooController {
+        public function fooAction() {}
+    }
+}