add support for named arguments #998

Author: Haehnchen

tests/fr/adrienbrault/idea/symfony2plugin/tests/dic/container/util/ServiceContainerUtilTest.java

@@ -2,13 +2,17 @@
 
 import com.google.gson.Gson;
 import com.intellij.openapi.util.Condition;
+import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiFile;
 import com.intellij.util.containers.ContainerUtil;
 import fr.adrienbrault.idea.symfony2plugin.dic.container.ServiceInterface;
 import fr.adrienbrault.idea.symfony2plugin.dic.container.ServiceSerializable;
+import fr.adrienbrault.idea.symfony2plugin.dic.container.dict.ServiceTypeHint;
 import fr.adrienbrault.idea.symfony2plugin.dic.container.util.ServiceContainerUtil;
+import fr.adrienbrault.idea.symfony2plugin.stubs.ContainerCollectionResolver;
 import fr.adrienbrault.idea.symfony2plugin.tests.SymfonyLightCodeInsightFixtureTestCase;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.yaml.psi.YAMLScalar;
 
 import java.io.File;
 import java.util.Arrays;
@@ -32,6 +36,8 @@ public void setUp() throws Exception {
 
         myFixture.configureByFile("usage.services.xml");
         myFixture.configureByFile("usage1.services.xml");
+
+        myFixture.configureByFile("classes.php");
     }
 
     public String getTestDataPath() {
@@ -199,6 +205,29 @@ public void testXmlFileScopeDefaultsForSymfony33() {
         assertTrue(defaultsOverwrite.isPublic());
     }
 
+    /**
+     * @see fr.adrienbrault.idea.symfony2plugin.dic.container.util.ServiceContainerUtil#getYamlConstructorTypeHint
+     */
+    public void testGetYamlConstructorTypeHint() {
+        myFixture.configureByText("test.yml", "" +
+            "services:\n" +
+            "   NamedArgument\\Foobar:\n" +
+            "       arguments: ['<caret>']\n"
+        );
+
+        PsiElement psiElement = myFixture.getFile().findElementAt(myFixture.getCaretOffset());
+
+        YAMLScalar parent = (YAMLScalar) psiElement.getParent();
+
+        ServiceTypeHint typeHint = ServiceContainerUtil.getYamlConstructorTypeHint(
+            parent,
+            new ContainerCollectionResolver.LazyServiceCollector(getProject())
+        );
+
+        assertEquals(0, typeHint.getIndex());
+        assertEquals("__construct", typeHint.getMethod().getName());
+    }
+
     private static class MyStringServiceInterfaceCondition implements Condition<ServiceInterface> {
 
         @NotNull

tests/fr/adrienbrault/idea/symfony2plugin/tests/dic/container/util/fixtures/classes.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace NamedArgument
+{
+    class Foobar
+    {
+        public function __construct(Foobar $foobar)
+        {
+        }
+    }
+}