Merge pull request #2161 from Giskard-AI/fix/2156-bug-modulenotfounderror-no-module-named-ipython

chore(deps): add IPython dependency and improve import structure in r…

Author: henchaves

giskard/rag/report.py

@@ -7,7 +7,6 @@
 import matplotlib
 import numpy as np
 import pandas as pd
-from IPython.core.display import HTML
 
 from ..llm.client.base import LLMClient
 from ..llm.embeddings.base import BaseEmbedding
@@ -135,6 +134,8 @@ def to_html(self, filename=None, embed=False):
             return
 
         if embed:
+            from IPython.core.display import HTML
+
             return HTML(f'<iframe srcdoc="{escape(html)}" width=100% height=800px></iframe>')
         return html
 

pdm.lock

@@ -174,6 +174,7 @@ dependencies = [
     "colorama",                 # needed for the scan
     "num2words>=0.5.13",
     "griffe>=1.0.0,<2.0.0",
+    "ipython",
 ]
 
 [project.optional-dependencies]

pyproject.toml

@@ -2,6 +2,7 @@
 from unittest.mock import Mock, patch
 
 import numpy as np
+import pytest
 from bokeh.plotting import figure
 
 from giskard.rag import QATestset, RAGReport
@@ -98,6 +99,15 @@ def test_report_plots():
     assert len(histograms["Question"]["simple"]) == 4
 
 
+@pytest.mark.parametrize("embed", [False, True])
+def test_report_to_html(embed):
+    """Test that to_html works correctly with different embed parameter values."""
+    testset, answers, metrics_results = _create_test_data()
+
+    report = RAGReport(testset, answers, metrics_results)
+    report.to_html(embed=embed)
+
+
 def test_report_save_load(tmp_path):
     testset, answers, metrics_results = _create_test_data(with_documents=True)
     llm_client = Mock()