Combine iter records range into iter records #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using iterRecords with a range option should be faster than calling record within a loop, since we avoid the multiple calls to seek.
This reverts commit e41b03c. JamesParrott pointed that I did not understand the way `__record` works: __record does not use oid to find the correct record, it just assumes it is the correct oid for the current position.
Using the method `iterRecords_range` should be somewhat faster than calling the method `record` within a loop, since we avoid the repeated calls to seek inside `record`.
…eek(0) before f.seek(..)
… returned as from Reader.record
… detail, not a shapefile record property)
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.