Merge pull request #1666 from Freika/dev

0.30.10

Author: Freika

.app_version

@@ -1 +1 @@
-0.30.9
+0.30.10

CHANGELOG.md

@@ -4,6 +4,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+# [0.30.10] - 2025-08-22
+
+## Added
+
+- `POST /api/v1/visits` endpoint.
+- User now can create visits manually on the map.
+- User can now delete a visit by clicking on the delete button in the visit popup.
+- Import failure now throws an internal server error.
+
+## Changed
+
+- Source of imports is now being detected automatically.
+
 
 # [0.30.9] - 2025-08-19
 

app/assets/builds/tailwind.css

@@ -33,6 +33,40 @@
   box-shadow: 0 1px 4px rgba(0, 0, 0, 0.3);
 }
 
+/* Add Visit Marker Styles */
+.add-visit-marker {
+  display: flex !important;
+  align-items: center;
+  justify-content: center;
+  font-size: 20px;
+  background: white;
+  border: 2px solid #007bff;
+  border-radius: 50%;
+  box-shadow: 0 2px 8px rgba(0, 123, 255, 0.3);
+  animation: pulse-visit 2s infinite;
+}
+
+@keyframes pulse-visit {
+  0% {
+    transform: scale(1);
+    box-shadow: 0 2px 8px rgba(0, 123, 255, 0.3);
+  }
+  50% {
+    transform: scale(1.1);
+    box-shadow: 0 4px 12px rgba(0, 123, 255, 0.5);
+  }
+  100% {
+    transform: scale(1);
+    box-shadow: 0 2px 8px rgba(0, 123, 255, 0.3);
+  }
+}
+
+/* Visit Form Popup Styles */
+.visit-form-popup .leaflet-popup-content-wrapper {
+  border-radius: 8px;
+  box-shadow: 0 4px 20px rgba(0, 0, 0, 0.15);
+}
+
 .leaflet-right-panel.controls-shifted {
   right: 310px;
 }

app/assets/stylesheets/application.tailwind.css

@@ -10,6 +10,19 @@ def index
     render json: serialized_visits
   end
 
+  def create
+    service = Visits::Create.new(current_api_user, visit_params)
+
+    result = service.call
+
+    if result
+      render json: Api::VisitSerializer.new(service.visit).call
+    else
+      error_message = service.errors || 'Failed to create visit'
+      render json: { error: error_message }, status: :unprocessable_entity
+    end
+  end
+
   def update
     visit = current_api_user.visits.find(params[:id])
     visit = update_visit(visit)
@@ -62,10 +75,25 @@ def bulk_update
     end
   end
 
+  def destroy
+    visit = current_api_user.visits.find(params[:id])
+
+    if visit.destroy
+      head :no_content
+    else
+      render json: {
+        error: 'Failed to delete visit',
+        errors: visit.errors.full_messages
+      }, status: :unprocessable_entity
+    end
+  rescue ActiveRecord::RecordNotFound
+    render json: { error: 'Visit not found' }, status: :not_found
+  end
+
   private
 
   def visit_params
-    params.require(:visit).permit(:name, :place_id, :status)
+    params.require(:visit).permit(:name, :place_id, :status, :latitude, :longitude, :started_at, :ended_at)
   end
 
   def merge_params
@@ -78,6 +106,8 @@ def bulk_update_params
 
   def update_visit(visit)
     visit_params.each do |key, value|
+      next if %w[latitude longitude].include?(key.to_s)
+
       visit[key] = value
       visit.name = visit.place.name if visit_params[:place_id].present?
     end

app/controllers/api/v1/visits_controller.rb

@@ -43,8 +43,7 @@ def create
     raw_files = Array(files_params).reject(&:blank?)
 
     if raw_files.empty?
-      redirect_to new_import_path, alert: 'No files were selected for upload', status: :unprocessable_entity
-      return
+      redirect_to new_import_path, alert: 'No files were selected for upload', status: :unprocessable_entity and return
     end
 
     created_imports = []
@@ -59,11 +58,11 @@ def create
     if created_imports.any?
       redirect_to imports_url,
                   notice: "#{created_imports.size} files are queued to be imported in background",
-                  status: :see_other
+                  status: :see_other and return
     else
       redirect_to new_import_path,
                   alert: 'No valid file references were found. Please upload files using the file selector.',
-                  status: :unprocessable_entity
+                  status: :unprocessable_entity and return
     end
   rescue StandardError => e
     if created_imports.present?
@@ -95,26 +94,37 @@ def authorize_import
   end
 
   def import_params
-    params.require(:import).permit(:name, :source, files: [])
+    params.require(:import).permit(:name, files: [])
   end
 
   def create_import_from_signed_id(signed_id)
     Rails.logger.debug "Creating import from signed ID: #{signed_id[0..20]}..."
 
     blob = ActiveStorage::Blob.find_signed(signed_id)
 
-    import = current_user.imports.build(
-      name: blob.filename.to_s,
-      source: params[:import][:source]
-    )
-
+    import = current_user.imports.build(name: blob.filename.to_s)
     import.file.attach(blob)
+    import.source = detect_import_source(import.file) if import.source.blank?
 
     import.save!
 
     import
   end
 
+  def detect_import_source(file_attachment)
+    temp_file_path = Imports::SecureFileDownloader.new(file_attachment).download_to_temp_file
+
+    Imports::SourceDetector.new_from_file_header(temp_file_path).detect_source
+  rescue StandardError => e
+    Rails.logger.warn "Failed to auto-detect import source for #{file_attachment.filename}: #{e.message}"
+    nil
+  ensure
+    # Cleanup temp file
+    if temp_file_path && File.exist?(temp_file_path)
+      File.unlink(temp_file_path)
+    end
+  end
+
   def validate_points_limit
     limit_exceeded = PointsLimitExceeded.new(current_user).call
 

app/controllers/imports_controller.rb

@@ -1,6 +1,5 @@
 // Configure your import map in config/importmap.rb. Read more: https://github.com/rails/importmap-rails
 
-import "@rails/ujs"
 import "@rails/actioncable"
 import "controllers"
 import "@hotwired/turbo-rails"