Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: FortySevenEffects/arduino_midi_library
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: FortySevenEffects/arduino_midi_library
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr/hyperbolist/232
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 8 files changed
  • 2 contributors

Commits on Oct 8, 2022

  1. thru filter overhaul 

    * resolves #40 with franky47's proposed thru filter overhaul
* removes thru filter modes
* adds thru filter callback
* adds thru map callback
* old thru filter unit tests have been replicated with filter callbacks
* does not yet include documentation changes

I believe this implements the latest proposal for #40 and exercises
everything necessary in the unit tests, including the immutability of
`mMessage` after a thru map callback has modified the outgoing message.

The thru filter callbacks in the unit tests are not suitable for copying
and pasting by end-users due to the difference in the MIDI namespace
when setup via the unit tests vs via `MIDI_CREATE_DEFAULT_INSTANCE()`.

If the changes here are deemed suitable, I'll work on documentation.
    @hyperbolist @franky47
    hyperbolist authored and franky47 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    a6c3a48 View commit details
    Browse the repository at this point in the history

  2. makes changes requested in #232 discussion

    @hyperbolist @franky47
    hyperbolist authored and franky47 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    1fe67be View commit details
    Browse the repository at this point in the history

  3. uses Transport::thruActivated for initial thru state

    @hyperbolist @franky47
    hyperbolist authored and franky47 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    4469f2a View commit details
    Browse the repository at this point in the history

  4. chore: Add example

    @franky47
    franky47 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    c2a838d View commit details
    Browse the repository at this point in the history

  5. feat: Export type definitions when using macros 

    Types have names prepended by the port name
(defaults to `MIDI`), to allow multi-port applications.

This allows referencing those types elsewhere in the
application, without re-writing the template arguments,
and simplifies referencing the underlying Message type,
for SoftThru `filter`/`map`function definitions.

Proposition & discussion:
#232 (comment)
    @franky47
    franky47 committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    f42c344 View commit details
    Browse the repository at this point in the history
Loading