Place a time limit on TestFileHandle.test_readWriteHandlers()

beccadax · beccadax · commit e80678b2e703 · 2019-05-13T14:00:40.000-07:00
This test seems to sometimes fail, which can make it hang forever. Give it a still-generous-but-not-infinite timeout so it at least fails gracefully when it fails. https://bugs.swift.org/browse/SR-10680
diff --git a/TestFoundation/TestFileHandle.swift b/TestFoundation/TestFileHandle.swift
@@ -488,7 +488,7 @@ class TestFileHandle : XCTestCase {
                 try? handle.write(contentsOf: self.content)
             }
             
-            let result = semaphore.wait(timeout: .distantFuture)
+            let result = semaphore.wait(timeout: .now() + .seconds(30))
             XCTAssertEqual(result, .success, "Waiting on the semaphore should not have had time to time out")
             XCTAssertTrue(notificationReceived, "Notification should be sent")
         }

Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,7 @@ class TestFileHandle : XCTestCase {`
`488`	`488`	`try? handle.write(contentsOf: self.content)`
`489`	`489`	`}`
`490`	`490`
`491`		`- let result = semaphore.wait(timeout: .distantFuture)`
	`491`	`+ let result = semaphore.wait(timeout: .now() + .seconds(30))`
`492`	`492`	`XCTAssertEqual(result, .success, "Waiting on the semaphore should not have had time to time out")`
`493`	`493`	`XCTAssertTrue(notificationReceived, "Notification should be sent")`
`494`	`494`	`}`