Merge pull request swiftlang#2365 from compnerd/not-all-compilers-are-equal

compnerd · web-flow · commit c2adcdcc62ee · 2019-06-19T08:06:29.000-07:00
CoreFoundation: fix incorrect check
diff --git a/CoreFoundation/Base.subproj/CFKnownLocations.c b/CoreFoundation/Base.subproj/CFKnownLocations.c
@@ -99,7 +99,7 @@ CFURLRef _Nullable _CFKnownLocationCreatePreferencesURLForUser(CFKnownLocationUs
       abort();
     case _kCFKnownLocationUserCurrent: {
       const char *buffer = getenv("CFFIXED_USER_HOME");
-      if (buffer == NULL || *buffer = '\0') {
+      if (buffer == NULL || *buffer == '\0') {
         CFLog(__kCFLogAssertion, CFSTR("CFFIXED_USER_HOME is unset"));
         HALT;
       }

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ CFURLRef _Nullable _CFKnownLocationCreatePreferencesURLForUser(CFKnownLocationUs`
`99`	`99`	`abort();`
`100`	`100`	`case _kCFKnownLocationUserCurrent: {`
`101`	`101`	`const char *buffer = getenv("CFFIXED_USER_HOME");`
`102`		`- if (buffer == NULL \|\| *buffer = '\0') {`
	`102`	`+ if (buffer == NULL \|\| *buffer == '\0') {`
`103`	`103`	`CFLog(__kCFLogAssertion, CFSTR("CFFIXED_USER_HOME is unset"));`
`104`	`104`	`HALT;`
`105`	`105`	`}`