Skip to content

Commit 57fbbbf

Browse files
ikesyoikesyo
committed
[gardening] Remove unnecessary breaks
1 parent 554ddd6 commit 57fbbbf

11 files changed

+0
-127
lines changed

‎Foundation/Boxing.swift

-2
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,8 @@ extension _SwiftNativeFoundationType {
106106
switch __wrapped {
107107
case .Immutable(let i):
108108
i.release()
109-
break
110109
case .Mutable(let m):
111110
m.release()
112-
break
113111
}
114112
}
115113

‎Foundation/Data.swift

-38
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,10 @@ public final class _DataStorage {
188188
switch _backing {
189189
case .swift:
190190
block(UnsafeBufferPointer<UInt8>(start: _bytes?.assumingMemoryBound(to: UInt8.self), count: _length), 0, &stop)
191-
break
192191
case .immutable:
193192
block(UnsafeBufferPointer<UInt8>(start: _bytes?.assumingMemoryBound(to: UInt8.self), count: _length), 0, &stop)
194-
break
195193
case .mutable:
196194
block(UnsafeBufferPointer<UInt8>(start: _bytes?.assumingMemoryBound(to: UInt8.self), count: _length), 0, &stop)
197-
break
198195
case .customReference(let d):
199196
d.enumerateBytes { (ptr, range, stop) in
200197
var stopv = false
@@ -204,7 +201,6 @@ public final class _DataStorage {
204201
stop.pointee = true
205202
}
206203
}
207-
break
208204
case .customMutableReference(let d):
209205
d.enumerateBytes { (ptr, range, stop) in
210206
var stopv = false
@@ -214,7 +210,6 @@ public final class _DataStorage {
214210
stop.pointee = true
215211
}
216212
}
217-
break
218213
}
219214
}
220215

@@ -310,27 +305,22 @@ public final class _DataStorage {
310305
_needToZero = true
311306
}
312307
_length = newLength
313-
break
314308
case .immutable(let d):
315309
let data = d.mutableCopy() as! NSMutableData
316310
data.length = length
317311
_backing = .mutable(data)
318312
_length = length
319313
_bytes = data.mutableBytes
320-
break
321314
case .mutable(let d):
322315
d.length = length
323316
_length = length
324317
_bytes = d.mutableBytes
325-
break
326318
case .customReference(let d):
327319
let data = d.mutableCopy() as! NSMutableData
328320
data.length = length
329321
_backing = .customMutableReference(data)
330-
break
331322
case .customMutableReference(let d):
332323
d.length = length
333-
break
334324
}
335325
}
336326

@@ -345,27 +335,22 @@ public final class _DataStorage {
345335
}
346336
_length = newLength
347337
_DataStorage.move(_bytes!.advanced(by: origLength), bytes, length)
348-
break
349338
case .immutable(let d):
350339
let data = d.mutableCopy() as! NSMutableData
351340
data.append(bytes, length: length)
352341
_backing = .mutable(data)
353342
_length = data.length
354343
_bytes = data.mutableBytes
355-
break
356344
case .mutable(let d):
357345
d.append(bytes, length: length)
358346
_length = d.length
359347
_bytes = d.mutableBytes
360-
break
361348
case .customReference(let d):
362349
let data = d.mutableCopy() as! NSMutableData
363350
data.append(bytes, length: length)
364351
_backing = .customReference(data)
365-
break
366352
case .customMutableReference(let d):
367353
d.append(bytes, length: length)
368-
break
369354
}
370355

371356
}
@@ -400,27 +385,22 @@ public final class _DataStorage {
400385
memset(_bytes!.advanced(by: origLength), 0, extraLength)
401386
}
402387
_length = newLength
403-
break
404388
case .immutable(let d):
405389
let data = d.mutableCopy() as! NSMutableData
406390
data.increaseLength(by: extraLength)
407391
_backing = .mutable(data)
408392
_length += extraLength
409393
_bytes = data.mutableBytes
410-
break
411394
case .mutable(let d):
412395
d.increaseLength(by: extraLength)
413396
_length += extraLength
414397
_bytes = d.mutableBytes
415-
break
416398
case .customReference(let d):
417399
let data = d.mutableCopy() as! NSMutableData
418400
data.increaseLength(by: extraLength)
419401
_backing = .customReference(data)
420-
break
421402
case .customMutableReference(let d):
422403
d.increaseLength(by: extraLength)
423-
break
424404
}
425405

426406
}
@@ -432,12 +412,10 @@ public final class _DataStorage {
432412
fallthrough
433413
case .mutable:
434414
_bytes!.advanced(by: index).assumingMemoryBound(to: UInt8.self).pointee = value
435-
break
436415
default:
437416
var theByte = value
438417
let range = NSRange(location: index, length: 1)
439418
replaceBytes(in: range, with: &theByte, length: 1)
440-
break
441419
}
442420

443421
}
@@ -456,27 +434,22 @@ public final class _DataStorage {
456434
_length = newLength
457435
}
458436
_DataStorage.move(_bytes!.advanced(by: range.location), bytes!, range.length)
459-
break
460437
case .immutable(let d):
461438
let data = d.mutableCopy() as! NSMutableData
462439
data.replaceBytes(in: range, withBytes: bytes!)
463440
_backing = .mutable(data)
464441
_length = data.length
465442
_bytes = data.mutableBytes
466-
break
467443
case .mutable(let d):
468444
d.replaceBytes(in: range, withBytes: bytes!)
469445
_length = d.length
470446
_bytes = d.mutableBytes
471-
break
472447
case .customReference(let d):
473448
let data = d.mutableCopy() as! NSMutableData
474449
data.replaceBytes(in: range, withBytes: bytes!)
475450
_backing = .customMutableReference(data)
476-
break
477451
case .customMutableReference(let d):
478452
d.replaceBytes(in: range, withBytes: bytes!)
479-
break
480453
}
481454
}
482455

@@ -509,28 +482,23 @@ public final class _DataStorage {
509482
if resultingLength < currentLength {
510483
setLength(resultingLength)
511484
}
512-
break
513485
case .immutable(let d):
514486
let data = d.mutableCopy() as! NSMutableData
515487
data.replaceBytes(in: range, withBytes: replacementBytes, length: replacementLength)
516488
_backing = .mutable(data)
517489
_length = replacementLength
518490
_bytes = data.mutableBytes
519-
break
520491
case .mutable(let d):
521492
d.replaceBytes(in: range, withBytes: replacementBytes, length: replacementLength)
522493
_backing = .mutable(d)
523494
_length = replacementLength
524495
_bytes = d.mutableBytes
525-
break
526496
case .customReference(let d):
527497
let data = d.mutableCopy() as! NSMutableData
528498
data.replaceBytes(in: range, withBytes: replacementBytes, length: replacementLength)
529499
_backing = .customMutableReference(data)
530-
break
531500
case .customMutableReference(let d):
532501
d.replaceBytes(in: range, withBytes: replacementBytes, length: replacementLength)
533-
break
534502
}
535503
}
536504

@@ -547,27 +515,22 @@ public final class _DataStorage {
547515
_length = newLength
548516
}
549517
memset(_bytes!.advanced(by: range.location), 0, range.length)
550-
break
551518
case .immutable(let d):
552519
let data = d.mutableCopy() as! NSMutableData
553520
data.resetBytes(in: range)
554521
_backing = .mutable(data)
555522
_length = data.length
556523
_bytes = data.mutableBytes
557-
break
558524
case .mutable(let d):
559525
d.resetBytes(in: range)
560526
_length = d.length
561527
_bytes = d.mutableBytes
562-
break
563528
case .customReference(let d):
564529
let data = d.mutableCopy() as! NSMutableData
565530
data.resetBytes(in: range)
566531
_backing = .customMutableReference(data)
567-
break
568532
case .customMutableReference(let d):
569533
d.resetBytes(in: range)
570-
break
571534
}
572535

573536
}
@@ -709,7 +672,6 @@ public final class _DataStorage {
709672
switch _backing {
710673
case .swift:
711674
_freeBytes()
712-
break
713675
default:
714676
break
715677
}

‎Foundation/NSCalendar.swift

-16
Original file line numberDiff line numberDiff line change
@@ -1619,52 +1619,36 @@ open class NSDateComponents : NSObject, NSCopying, NSSecureCoding {
16191619
switch unit {
16201620
case NSCalendar.Unit.era:
16211621
era = value
1622-
break
16231622
case NSCalendar.Unit.year:
16241623
year = value
1625-
break
16261624
case NSCalendar.Unit.month:
16271625
month = value
1628-
break
16291626
case NSCalendar.Unit.day:
16301627
day = value
1631-
break
16321628
case NSCalendar.Unit.hour:
16331629
hour = value
1634-
break
16351630
case NSCalendar.Unit.minute:
16361631
minute = value
1637-
break
16381632
case NSCalendar.Unit.second:
16391633
second = value
1640-
break
16411634
case NSCalendar.Unit.nanosecond:
16421635
nanosecond = value
1643-
break
16441636
case NSCalendar.Unit.weekday:
16451637
weekday = value
1646-
break
16471638
case NSCalendar.Unit.weekdayOrdinal:
16481639
weekdayOrdinal = value
1649-
break
16501640
case NSCalendar.Unit.quarter:
16511641
quarter = value
1652-
break
16531642
case NSCalendar.Unit.weekOfMonth:
16541643
weekOfMonth = value
1655-
break
16561644
case NSCalendar.Unit.weekOfYear:
16571645
weekOfYear = value
1658-
break
16591646
case NSCalendar.Unit.yearForWeekOfYear:
16601647
yearForWeekOfYear = value
1661-
break
16621648
case NSCalendar.Unit.calendar:
16631649
print(".Calendar cannot be set via \(#function)")
1664-
break
16651650
case NSCalendar.Unit.timeZone:
16661651
print(".TimeZone cannot be set via \(#function)")
1667-
break
16681652
default:
16691653
break
16701654
}

‎Foundation/NSDecimal.swift

-16
Original file line numberDiff line numberDiff line change
@@ -249,28 +249,20 @@ extension Decimal : Hashable, Comparable {
249249
switch index {
250250
case 0:
251251
d = d * 65536 + Double(_mantissa.0)
252-
break
253252
case 1:
254253
d = d * 65536 + Double(_mantissa.1)
255-
break
256254
case 2:
257255
d = d * 65536 + Double(_mantissa.2)
258-
break
259256
case 3:
260257
d = d * 65536 + Double(_mantissa.3)
261-
break
262258
case 4:
263259
d = d * 65536 + Double(_mantissa.4)
264-
break
265260
case 5:
266261
d = d * 65536 + Double(_mantissa.5)
267-
break
268262
case 6:
269263
d = d * 65536 + Double(_mantissa.6)
270-
break
271264
case 7:
272265
d = d * 65536 + Double(_mantissa.7)
273-
break
274266
default:
275267
fatalError("conversion overflow")
276268
}
@@ -393,28 +385,20 @@ extension Decimal {
393385
switch i {
394386
case 0:
395387
_mantissa.0 = UInt16(truncatingBitPattern:mantissa)
396-
break
397388
case 1:
398389
_mantissa.1 = UInt16(truncatingBitPattern:mantissa)
399-
break
400390
case 2:
401391
_mantissa.2 = UInt16(truncatingBitPattern:mantissa)
402-
break
403392
case 3:
404393
_mantissa.3 = UInt16(truncatingBitPattern:mantissa)
405-
break
406394
case 4:
407395
_mantissa.4 = UInt16(truncatingBitPattern:mantissa)
408-
break
409396
case 5:
410397
_mantissa.5 = UInt16(truncatingBitPattern:mantissa)
411-
break
412398
case 6:
413399
_mantissa.6 = UInt16(truncatingBitPattern:mantissa)
414-
break
415400
case 7:
416401
_mantissa.7 = UInt16(truncatingBitPattern:mantissa)
417-
break
418402
default:
419403
fatalError("initialization overflow")
420404
}

‎Foundation/NSHost.swift

-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,8 @@ open class Host: NSObject {
6464
switch (_type) {
6565
case .name:
6666
flags = AI_PASSIVE | AI_CANONNAME
67-
break
6867
case .address:
6968
flags = AI_PASSIVE | AI_CANONNAME | AI_NUMERICHOST
70-
break
7169
case .current:
7270
_resolveCurrent()
7371
return

0 commit comments

Comments
 (0)