Merge pull request swiftlang#2243 from compnerd/rube-goldberg-device

TestFoundation: make `test_nullDevice` test more portable

Author: compnerd

TestFoundation/TestFileHandle.swift

@@ -289,10 +289,11 @@ class TestFileHandle : XCTestCase {
                        "\(FileHandle.readCompletionNotification.rawValue) is not equal to NSFileHandleReadCompletionNotification")
     }
 
+#if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT
     func test_nullDevice() {
         let fh = FileHandle.nullDevice
 
-        XCTAssertEqual(fh.fileDescriptor, -1)
+        XCTAssertFalse(fh._isPlatformHandleValid)
         fh.closeFile()
         fh.seek(toFileOffset: 10)
         XCTAssertEqual(fh.offsetInFile, 0)
@@ -307,6 +308,7 @@ class TestFileHandle : XCTestCase {
         fh.seek(toFileOffset: 0)
         XCTAssertEqual(fh.readDataToEndOfFile().count, 0)
     }
+#endif
 
     func test_truncateFile() {
         let url: URL = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent(ProcessInfo.processInfo.globallyUniqueString, isDirectory: false)
@@ -502,7 +504,6 @@ class TestFileHandle : XCTestCase {
             ("testWritingWithBuffer", testWritingWithBuffer),
             ("testWritingWithMultiregionData", testWritingWithMultiregionData),
             ("test_constants", test_constants),
-            ("test_nullDevice", test_nullDevice),
             ("test_truncateFile", test_truncateFile),
             ("test_readabilityHandlerCloseFileRace", test_readabilityHandlerCloseFileRace),
             ("test_readabilityHandlerCloseFileRaceWithError", test_readabilityHandlerCloseFileRaceWithError),
@@ -518,6 +519,7 @@ class TestFileHandle : XCTestCase {
 #if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT
         tests.append(contentsOf: [
             ("test_fileDescriptor", test_fileDescriptor),
+            ("test_nullDevice", test_nullDevice),
             ("testHandleCreationAndCleanup", testHandleCreationAndCleanup),
             ("testOffset", testOffset),
         ])