Skip to content

Commit 0b573bd

Browse files
committed
Fix Host.isEqual
1 parent fffb60b commit 0b573bd

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

Foundation/Host.swift

+2-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ open class Host: NSObject {
7575
}
7676

7777
open func isEqual(to aHost: Host) -> Bool {
78-
return aHost._addresses == _addresses && aHost._info == _info && aHost._names == _names && aHost._resolved == _resolved && aHost._type == _type
78+
if self === aHost { return true }
79+
return _addresses.firstIndex { aHost._addresses.contains($0) } != nil
7980
}
8081

8182
internal func _resolveCurrent() {

TestFoundation/TestHost.swift

+4-8
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class TestHost: XCTestCase {
1212
static var allTests: [(String, (TestHost) -> () throws -> Void)] {
1313
return [
1414
("test_addressesDoNotGrow", test_addressesDoNotGrow),
15-
("test_isEqual_positive", test_isEqual_positive),
16-
("test_isEqual_negative", test_isEqual_negative)
15+
("test_isEqual", test_isEqual)
1716
]
1817
}
1918

@@ -35,16 +34,13 @@ class TestHost: XCTestCase {
3534
XCTAssertEqual(swiftAddressesSecond.count, swiftAddressesFirst.count)
3635
}
3736

38-
func test_isEqual_positive() {
37+
func test_isEqual() {
3938
let host0 = Host(address: "8.8.8.8")
4039
let host1 = Host(address: "8.8.8.8")
4140
XCTAssertTrue(host0.isEqual(to: host1))
42-
}
4341

44-
func test_isEqual_negative() {
45-
let host0 = Host(address: "8.8.8.8")
46-
let host1 = Host(address: "8.8.8.9")
47-
XCTAssertFalse(host0.isEqual(to: host1))
42+
let host2 = Host(address: "8.8.8.9")
43+
XCTAssertFalse(host0.isEqual(to: host2))
4844
}
4945
}
5046

0 commit comments

Comments
 (0)