Skip to content

Commit 80c6615

Browse files
creyndersrandycoulman
authored andcommitted
eject: Additionally remove react-scripts from dependencies (facebook#1458)
ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present.
1 parent 5bbdd83 commit 80c6615

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

packages/react-scripts/scripts/eject.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,14 @@ prompt(
9393

9494
console.log(cyan('Updating the dependencies'));
9595
var ownPackageName = ownPackage.name;
96-
console.log(' Removing ' + cyan(ownPackageName) + ' from devDependencies');
97-
delete appPackage.devDependencies[ownPackageName];
96+
if (appPackage.devDependencies[ownPackageName]) {
97+
console.log(' Removing ' + cyan(ownPackageName) + ' from devDependencies');
98+
delete appPackage.devDependencies[ownPackageName];
99+
}
100+
if (appPackage.dependencies[ownPackageName]) {
101+
console.log(' Removing ' + cyan(ownPackageName) + ' from dependencies');
102+
delete appPackage.dependencies[ownPackageName];
103+
}
98104

99105
Object.keys(ownPackage.dependencies).forEach(function (key) {
100106
// For some reason optionalDependencies end up in dependencies after install

0 commit comments

Comments
 (0)