Skip to content

Commit be167fc

Browse files
Merge pull request snowflakedb#355 from snowflakedb/prep-1.2.6
Prep 1.2.6
2 parents 79bd89c + b322cfe commit be167fc

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

Snowflake.Data/Core/HttpUtil.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,12 +242,12 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
242242
if (response != null)
243243
{
244244
if (response.IsSuccessStatusCode) {
245-
logger.Debug($"Success Response: {response.ToString()}");
245+
logger.Debug($"Success Response: StatusCode: {(int)response.StatusCode}, ReasonPhrase: '{response.ReasonPhrase}'");
246246
return response;
247247
}
248248
else
249249
{
250-
logger.Debug($"Failed Response: {response.ToString()}");
250+
logger.Debug($"Failed Response: StatusCode: {(int)response.StatusCode}, ReasonPhrase: '{response.ReasonPhrase}'");
251251
bool isRetryable = isRetryableHTTPCode((int)response.StatusCode);
252252
if (!isRetryable)
253253
{

Snowflake.Data/Core/RestRequester.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ internal interface IRestRequester
3232

3333
internal class RestRequester : IRestRequester
3434
{
35-
private static SFLogger logger = SFLoggerFactory.GetLogger<RestRequester>();
36-
3735
private static readonly RestRequester instance = new RestRequester();
3836

3937
private RestRequester()
@@ -56,7 +54,6 @@ public async Task<T> PostAsync<T>(IRestRequest request, CancellationToken cancel
5654
using (var response = await SendAsync(HttpMethod.Post, request, cancellationToken).ConfigureAwait(false))
5755
{
5856
var json = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
59-
logger.Debug($"Post response: {json}");
6057
return JsonConvert.DeserializeObject<T>(json);
6158
}
6259
}
@@ -72,23 +69,19 @@ public async Task<T> GetAsync<T>(IRestRequest request, CancellationToken cancell
7269
using (HttpResponseMessage response = await GetAsync(request, cancellationToken).ConfigureAwait(false))
7370
{
7471
var json = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
75-
logger.Debug($"Get response: {json}");
7672
return JsonConvert.DeserializeObject<T>(json);
7773
}
7874
}
7975

8076
public Task<HttpResponseMessage> GetAsync(IRestRequest request, CancellationToken cancellationToken)
8177
{
8278
HttpRequestMessage message = request.ToRequestMessage(HttpMethod.Get);
83-
logger.Debug($"Http method: {message.ToString()}, http request message: {message.ToString()}");
8479
return SendAsync(HttpMethod.Get, request, cancellationToken);
8580
}
8681

8782
public HttpResponseMessage Get(IRestRequest request)
8883
{
8984
HttpRequestMessage message = request.ToRequestMessage(HttpMethod.Get);
90-
logger.Debug($"Http method: {message.ToString()}, http request message: {message.ToString()}");
91-
9285
//Run synchronous in a new thread-pool task.
9386
return Task.Run(async () => await GetAsync(request, CancellationToken.None)).Result;
9487
}

Snowflake.Data/Snowflake.Data.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<Product>Snowflake Connector for .NET</Product>
1313
<Authors>howryu, tchen</Authors>
1414
<Copyright>Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved.</Copyright>
15-
<Version>1.2.5</Version>
15+
<Version>1.2.6</Version>
1616
<DebugType>Full</DebugType>
1717
</PropertyGroup>
1818

0 commit comments

Comments
 (0)