memset vector to 0 before AVX2 exponentiation

rtjk · rtjk · commit c8f7411fed13 · 2025-08-19T11:44:54.000+02:00
diff --git a/avx2/fp_arith.h b/avx2/fp_arith.h
@@ -528,7 +528,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]){
     /* res: expand, align */
     alignas(32) FP_ELEM res_x[ROUND_UP(N,EPI16_PER_REG)];
     /* in: convert from uint8 to uint16, expand, align */
-    alignas(32) FP_ELEM in_x[ROUND_UP(N,EPI16_PER_REG)];
+    alignas(32) FP_ELEM in_x[ROUND_UP(N,EPI16_PER_REG)] = {0};
     for (int i = 0; i < N; i++) {
         in_x[i] = in[i];
     }
diff --git a/generate/crypto_sign/cross-rsdpg-128-balanced/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-128-balanced/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-128-fast/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-128-fast/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-128-small/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-128-small/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-192-balanced/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-192-balanced/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-192-fast/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-192-fast/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-192-small/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-192-small/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-256-balanced/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-256-balanced/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-256-fast/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-256-fast/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}
diff --git a/generate/crypto_sign/cross-rsdpg-256-small/avx2/fp_arith.h b/generate/crypto_sign/cross-rsdpg-256-small/avx2/fp_arith.h
@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {
 	/* res: expand, align */
 	alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];
 	/* in: convert from uint8 to uint16, expand, align */
-	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];
+	alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};
 	for (int i = 0; i < N; i++) {
 		in_x[i] = in[i];
 	}

Original file line number	Diff line number	Diff line change
`@@ -528,7 +528,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]){`
`528`	`528`	`/* res: expand, align */`
`529`	`529`	`alignas(32) FP_ELEM res_x[ROUND_UP(N,EPI16_PER_REG)];`
`530`	`530`	`/* in: convert from uint8 to uint16, expand, align */`
`531`		`- alignas(32) FP_ELEM in_x[ROUND_UP(N,EPI16_PER_REG)];`
	`531`	`+ alignas(32) FP_ELEM in_x[ROUND_UP(N,EPI16_PER_REG)] = {0};`
`532`	`532`	`for (int i = 0; i < N; i++) {`
`533`	`533`	`in_x[i] = in[i];`
`534`	`534`	`}`
Original file line number	Diff line number	Diff line change
`@@ -340,7 +340,7 @@ void convert_restr_vec_to_fp(FP_ELEM res[N], const FZ_ELEM in[N]) {`
`340`	`340`	`/* res: expand, align */`
`341`	`341`	`alignas(32) FP_ELEM res_x[ROUND_UP(N, EPI16_PER_REG)];`
`342`	`342`	`/* in: convert from uint8 to uint16, expand, align */`
`343`		`- alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)];`
	`343`	`+ alignas(32) FP_ELEM in_x[ROUND_UP(N, EPI16_PER_REG)] = {0};`
`344`	`344`	`for (int i = 0; i < N; i++) {`
`345`	`345`	`in_x[i] = in[i];`
`346`	`346`	`}`