Fixes #16 JsonApi meta data should notbe serialized

Author: BlairJ

src/JsonApiSerializer.ts

@@ -9,7 +9,7 @@ import JsonApi = require('./JsonApi');
 //var jsdata: Function = require('js-data');
 
 
-const JSONAPI_META: string = '$_JSONAPIMETA_';
+export const JSONAPI_META: string = '$_JSONAPIMETA_';
 const jsonApiContentType: string = 'application/vnd.api+json';
 export const JSONAPI_RELATED_LINK: string = 'related';
 export const JSONAPI_PARENT_LINK: string = 'parent';
@@ -487,7 +487,7 @@ export class JsonApiHelper {
                 result.WithData(this.ObjectToJsonApiData(options, item));
             });
         } else {
-            // Not sure this is really necessary could just always send an array ?
+            // JsonAPI single object
             result.data = <any>this.ObjectToJsonApiData(options, contents);
         }
         return result;
@@ -876,7 +876,8 @@ export class JsonApiHelper {
 
         for (var prop in contents) {
             // Skip id attribute as it has already been copied to the id field out side of the attributes collection
-            if (prop === options.idAttribute) {
+            // Todo skip any non-json api compliant tags
+            if (prop === options.idAttribute || prop === JSONAPI_META || prop.indexOf('$') >= 0 ) {
                 continue;
             }
 
@@ -968,14 +969,16 @@ export class JsonApiHelper {
 
         //Get each child relationship
         for (var relationName in data.relationships) {
-            
             if (data.relationships[relationName]) {
 
                 // Relation name should be the local field name of a relationship.
                 var relationship = data.relationships[relationName];
 
                 // Data is truthy and is not an array or if an array is not empty
-                var hasData = (relationship.data && (!DSUTILS.isArray(relationship.data) || (DSUTILS.isArray(relationship.data) && (<JsonApi.JsonApiData[]>relationship.data).length > 0)));
+                var hasData = (relationship.data && (
+                    !DSUTILS.isArray(relationship.data) ||
+                    (DSUTILS.isArray(relationship.data) && (<JsonApi.JsonApiData[]>relationship.data).length > 0))
+                );
 
                 if (hasData) {
                     var joinTableFactory = null;

test/jsonApiSerializationSpec.js

@@ -383,4 +383,59 @@
 
         });
     });
+
+    describe('Meta Data', function () {
+        var ds;
+        var test = { config: {} };
+        
+        beforeEach(function () {
+            ds = new JSData.DS();
+            var dsHttpAdapter = new DSJsonApiAdapter.JsonApiAdapter({
+                queryTransform: queryTransform
+            });
+            ds.registerAdapter('jsonApi', dsHttpAdapter, { default: true });
+
+            test.config.User = ds.defineResource({
+                name: 'user',
+                idAttribute: 'id'
+            });
+            
+            test.jsonApiData = new DSJsonApiAdapter.JsonApi.JsonApiRequest();
+            test.jsonApiData.WithData(
+                new DSJsonApiAdapter.JsonApi.JsonApiData('user')
+                    .WithId('2')
+                    .WithAttribute('author', 'John')
+                    .WithAttribute('age', 31));
+            
+            test.model = [{ Id: '2', author: 'John', age: 31 }]; //ISMODEL: true, type: 'testuser'
+        });
+        
+        it('should not serialize meta data', function () {
+            var _this = this;
+            
+            setTimeout(function () {
+                assert.equal(1, _this.requests.length);
+                _this.requests[0].respond(200, { 'Content-Type': 'application/vnd.api+json' }, JSON.stringify(test.jsonApiData));
+            }, 30);
+            
+            return test.config.User.create({ author: 'John', age: 32 }).then(function (data) {
+                var user = test.config.User.get(2);
+                var meta = DSJsonApiAdapter.TryGetMetaData(user);
+                assert.isDefined(user, 'user should be in the store');
+                assert.isDefined(meta, 'user should have meta data in the store');
+                
+                setTimeout(function () {
+                    assert.equal(2, _this.requests.length, 'should make second request');
+                    
+                    var request = JSON.parse(_this.requests[1].requestBody);
+                    assert.isUndefined( request.data.attributes['$_JSONAPIMETA_'], 'should not send meta data');
+
+                    _this.requests[1].respond(200, { 'Content-Type': 'application/vnd.api+json' }, _this.requests[1].requestBody);
+                }, 30);
+
+                user.name = 'bob';
+                return test.config.User.save(user.id);
+            });
+        });
+    }); 
 });