one change. UnknownAction to UnknownActionError

Author: eric-s-s

Diff for: axelrod/actions.py

@@ -13,9 +13,9 @@
 from typing import Iterable
 
 
-class UnknownAction(ValueError):
+class UnknownActionError(ValueError):
     def __init__(self, *args):
-        super(UnknownAction, self).__init__(*args)
+        super(UnknownActionError, self).__init__(*args)
 
 
 class Actions(Enum):
@@ -49,15 +49,15 @@ def from_char(cls, character):
         elif character == 'D':
             return cls.D
         else:
-            raise UnknownAction('Character must be "C" or "D".')
+            raise UnknownActionError('Character must be "C" or "D".')
 
 # Type alias for actions.
 Action = Actions
 
 
 def flip_action(action: Action) -> Action:
     if not isinstance(action, Action):
-        raise UnknownAction('Not an Action')
+        raise UnknownActionError('Not an Action')
     return action.flip()
 
 

Diff for: axelrod/tests/unit/test_actions.py

@@ -1,6 +1,6 @@
 import unittest
 from axelrod import Actions, flip_action
-from axelrod.actions import str_to_actions, UnknownAction,  actions_to_str
+from axelrod.actions import str_to_actions, UnknownActionError,  actions_to_str
 
 C, D = Actions.C, Actions.D
 
@@ -34,25 +34,25 @@ def test_from_char(self):
         self.assertEqual(Actions.from_char('D'), D)
 
     def test_from_char_error(self):
-        self.assertRaises(UnknownAction, Actions.from_char, '')
-        self.assertRaises(UnknownAction, Actions.from_char, 'c')
-        self.assertRaises(UnknownAction, Actions.from_char, 'd')
-        self.assertRaises(UnknownAction, Actions.from_char, 'A')
+        self.assertRaises(UnknownActionError, Actions.from_char, '')
+        self.assertRaises(UnknownActionError, Actions.from_char, 'c')
+        self.assertRaises(UnknownActionError, Actions.from_char, 'd')
+        self.assertRaises(UnknownActionError, Actions.from_char, 'A')
 
     def test_flip_action(self):
         self.assertEqual(flip_action(D), C)
         self.assertEqual(flip_action(C), D)
 
     def test_flip_action_error(self):
-        self.assertRaises(UnknownAction, flip_action, 'R')
+        self.assertRaises(UnknownActionError, flip_action, 'R')
 
     def test_str_to_actions(self):
         self.assertEqual(str_to_actions(''), ())
         self.assertEqual(str_to_actions('C'), (C, ))
         self.assertEqual(str_to_actions('CDDC'), (C, D, D, C))
 
     def test_str_to_actions_fails_fast_and_raises_value_error(self):
-        self.assertRaises(UnknownAction, str_to_actions, 'Cc')
+        self.assertRaises(UnknownActionError, str_to_actions, 'Cc')
 
     def test_actions_to_str(self):
         self.assertEqual(actions_to_str([]), "")