Skip to content

Commit bcffee3

Browse files
committed
Handle failure to install local library in CI script
1 parent f3d6374 commit bcffee3

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
2323
- Library installation no longer "fails" if the library is already installed
2424
- Platform definition for `mega2560` now includes proper AVR compiler flag
2525
- `CppLibrary::vendor_bundle?` now asks where gems are, instead of assuming `vendor/bundle/`
26+
- `install_local_library` step in `arduino_ci_remote.rb` now properly surfaces any error message
2627

2728
### Security
2829

exe/arduino_ci_remote.rb

+12-7
Original file line numberDiff line numberDiff line change
@@ -248,17 +248,22 @@ def perform_compilation_tests(config)
248248
installed_library_path = attempt("Installing library under test") do
249249
@arduino_cmd.install_local_library(Pathname.new("."))
250250
end
251-
if installed_library_path.exist?
251+
252+
if !installed_library_path.nil? && installed_library_path.exist?
252253
inform("Library installed at") { installed_library_path.to_s }
253254
else
254255
assure_multiline("Library installed successfully") do
255-
# print out the contents of the deepest directory we actually find
256-
@arduino_cmd.lib_dir.ascend do |path_part|
257-
next unless path_part.exist?
258-
259-
break display_files(path_part)
256+
if installed_library_path.nil?
257+
puts @arduino_cmd.last_msg
258+
else
259+
# print out the contents of the deepest directory we actually find
260+
@arduino_cmd.lib_dir.ascend do |path_part|
261+
next unless path_part.exist?
262+
263+
break display_files(path_part)
264+
end
265+
false
260266
end
261-
false
262267
end
263268
end
264269
library_examples = @arduino_cmd.library_examples(installed_library_path)

0 commit comments

Comments
 (0)